The hashJoin, hashLeftOuterJoin, hashFullOuterJoin, hashIntersectByKey, hashSubtractByKey methods in com.spotify.scio.extra.sparkey.PairLargeHashSCollectionFunctions were shadowing the corresponding methods in com.spotify.scio.values.PairHashSCollectionFunctions.

As an example, the following test doesn't compile:

  it should "not shadow the regular hashJoin method" in {
    import com.spotify.scio.extra.sparkey._

    val sc = ScioContext()

    val lhsInput = Seq((1, "a"), (2, "c"), (3, "e"), (4, "g"))
    val rhsInput = Seq((1, "b"), (2, "d"), (3, "f"))

    val rhs = sc.parallelize(rhsInput)
    val lhs = sc.parallelize(lhsInput)

    val result = lhs
      .hashJoin(rhs)
      .materialize

    val scioResult = sc.run().waitUntilFinish()
    val expectedOutput = List((1,("a", "b")), (2,("c","d")), (3,("e","f")))

    scioResult.tap(result).value.toList should contain theSameElementsAs expectedOutput
}

This PR contains a breaking change that fixes this issue. I think renaming those (relatively new) methods to largeHash* makes more sense, since they all take an input like SideInput[SparkeySet[K]] or SideInput[SparkeyMap[K]]

Please let me know if this isn't an approach you want to consider and if you'd like to fix this another way.